Skip to content

tlv-account-resolution: return the unpack error in init and update - #210

Merged
joncinque merged 1 commit into
solana-program:mainfrom
Iamsohungrynow:fix/extra-metas-unpack-unwrap
Oct 27, 2026
Merged

joncinque merged 1 commit into
solana-program:mainfrom
Iamsohungrynow:fix/extra-metas-unpack-unwrap

Conversation

@Iamsohungrynow

Copy link
Copy Markdown
Contributor

ExtraAccountMetaList::init and update still unwrapped TlvStateMut::unpack, so data too short for a tlv header panicked instead of returning InvalidAccountData. #207 fixed the same thing in the read paths

ExtraAccountMetaList::init and update return a Result but still unwrapped
TlvStateMut::unpack, so data too short for a TLV header panicked instead of
returning InvalidAccountData. solana-program#207 fixed the same thing in the read paths.

@joncinque joncinque left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks

@joncinque
joncinque merged commit 07b9b49 into solana-program:main Oct 27, 2026
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants