Repository navigation
type-length-value: don't write the entry header when alloc fails - #209
Merged
joncinque merged 1 commit intoOct 27, 2026
Merged
Conversation
TlvStateMut::alloc wrote the type and length before checking that the value fits, so after an InvalidAccountData the buffer no longer unpacked and retrying the same alloc returned TypeAlreadyExists. It now checks first, like realloc_with_repetition already does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TlvStateMut::allocwrote the type and length before checking the value fits, so after anInvalidAccountDatathe buffer no longer unpacks and retrying the same alloc returnsTypeAlreadyExists. it now checks first, likerealloc_with_repetitionalready does