chore: cleaned up tests using native functionality

[fearphage]

Summary

Describe the goal of this PR. Mention any related Issue numbers.

• Removed try-catch wrappers from tests
• Replaced mock.returns(Promise.resolve(...)) with mock.resolves(...)
• Cleaned up assertions
• Remove async marker from synchronous tests

Details

Many tests were wrapped in try-catch blocks. This is a bit odd and awkward since failing tests fail by throwing AssertionErrors. I unwrapped the tests to allow them to fail as expected. The vast majority of this clean up is just using assert.rejects.

Note

The changes are much smaller than they appear. If you ignore the white space changes (from deleting the try-catch wrapper), it makes the changes much more easily digestible.

Requirements

• I've read and understood the Contributing Guidelines and have done my best effort to follow them.
• I've read and agree to the Code of Conduct.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 7e1f1b5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[salesforce-cla]

Thanks for the contribution! Before we can merge this, we need @fearphage to sign the Salesforce Inc. Contributor License Agreement.

[zimeg]

👋 Hey @fearphage! Before we review this could I ask you to sign the @salesforce-cla[bot] message above?