Repository navigation
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
dblock
force-pushed
the
fix/team-metadata
branch
from
October 25, 2026 20:31
e7f4f20 to
3283ee8
Compare
Danger ReportNo issues found. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #26 in the core framework. Refresh persisted workspace name/domain from the successful auth.test response already obtained by Team#ping!, without another Slack request. Derive domain from the workspace URL hostname. Avoid writes when neither field changes. Retain the existing ping response and missing-presence-scope handling.
Expose Team#update_info! for an authentication-only refresh without presence calls. Document an optional :started callback for applications wanting refreshes on startup; the default startup lifecycle still performs no additional authentication request. auth.test requires no additional scopes, avoiding a new team:read requirement. This updates metadata, not RTM socket state.
Verify the authenticated workspace ID before changing metadata, reject malformed names/URLs explicitly, and propagate authentication or persistence errors. UPGRADING explains that pings, including /api/status, can now write updated metadata and surface write failures.
Validation
API/model specs pass with Mongoid 9.1 and Active Record 8.1 on Ruby 4/Grape 4: 67 examples, 0 failures each. Focused lint passes. Seven regressions cover persisted metadata, no extra API request, standalone refresh, unchanged-record write avoidance, missing presence scope, failed authentication, mismatched workspace identity, and malformed URLs without partial updates.
Authored by Copilot (AI), on behalf of @dblock.