Repository navigation
feat: shellui migrate rewrites pages for template API changes - #78
Merged
Merged
Conversation
shellui update replaces a component but leaves the app's pages on the old API, so the build breaks. migrate reads the project's .razor and .cs files (not the installed components or build output), shows each changed line and asks before writing; --dry-run only shows, --yes writes without asking and is required outside an interactive terminal. Migrations, from the release notes' upgrade sections: - input: Input.InputVariant.X -> InputVariant.X - date-picker / time-picker: SelectedDate / SelectedTime (with Changed and @bind-) -> Value, on those tags only, so Calendar is untouched - pagination: OnPageChange -> CurrentPageChanged, unless the tag binds CurrentPage - calendar: reports SelectedDateChanged handlers that take a DateTime instead of DateTime?; nothing is rewritten Fixes #58
Each migration, tag scoping (Calendar left alone, > inside a quoted value), the bound-CurrentPage exception, skipping installed components and obj, the Calendar note and an up-to-date app.
Applied with shellui migrate pagination.
Contributor
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Merged
Shewart
added a commit
that referenced
this pull request
Oct 30, 2026
Release notes and version references for 0.4.0, the 0.4 stable release. It fixes a hang in `shellui add` on .NET 8 and 9 apps that this release's smoke test found, and the 0.4.0 notes describe those fixes. **In this release** (on main, plus #80) - #76: PromptSuggestions, Reasoning, ToolCall, Field, JsonViewer - #77: a real resizable panel group (`ResizablePanelGroup` / `Panel` / `Handle`) - #78: `shellui migrate` - #74: .NET 8 support, `shellui add all`, `shellui doctor`, `SonnerService.Clear`, destructive context menu items, safelist fix - the whole 0.4 alpha line (alpha.1 to alpha.3), summed up for people upgrading from 0.3.6 - #80: `add` no longer hangs on .NET 8/9, the CLI rolls forward to newer runtimes, `doctor` stops calling a fresh `app.css` stale, `list` counts fixed Not in it: #79 (ShellCharts instead of ApexCharts) stays a draft for a later release. **This PR** - `Directory.Build.props`: empty suffix, so both packages build as `0.4.0` - README, VERSIONING_STRATEGY, CLI_INSTALLATION, CLI_SYNTAX, FAQ, QUICKSTART and the version fallbacks move to `0.4.0`. The latest stable was still listed as 0.3.5, so 0.3.6 is now the previous stable. Installs no longer need `--version`. - `docs/RELEASE_NOTES.md`: the 0.4.0 section. `scripts/extract-release-notes.sh 0.4.0` extracts it. **Release checks.** Packed 0.4.0, with #80, installed from a local folder into a private tool path, using a throwaway NuGet cache so nothing local shadows the published packages. - Release build: 0 warnings. 540 tests on net8.0 and net10.0 (542 with #80). - Every command in a fresh .NET 10 app: `init --yes`, `add all` (244 files), `list`, `remove`, `update`, `migrate --dry-run`, `theme apply`, `theme update`, `doctor`. Builds 0/0. - `init` and `add all` in fresh .NET 8 and .NET 9 apps build 0/0 and `doctor` is clean. Before #80, `add all` hung on both. - All 98 direct targets together, including the `dashboard-*` and `auth-*` blocks, in `my-app` (.NET 10): 0/0, `doctor` clean. - Upgrade from the published 0.4.0-alpha.3: - An app with a page using the old APIs builds on alpha.3. - 0.4.0 `update` rewrites 55 components and replaces the targets file, and the app builds 0/0. - `migrate` rewrites the page (DatePicker, TimePicker, Pagination), it builds 0/0, and `doctor` is clean. - CLI templates in a browser: - suggestion chips; Reasoning folds to "Thought for 2 seconds"; Field shows the EditForm error; JSON tree folds - Resizable drags from 30/70 to 55/45 - no console errors - Packed `ShellUI.Components` in a .NET 8 app with `shellui-all.css`, in light and dark mode: - the new components render; the resizable drag and suggestion chips work - Dialog focus trap: Tab stays inside, Escape closes and returns focus - `shellui.js` loads through the package's JS initializer, with no console errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #58.
shellui updatereplaces a component but leaves your pages on the old API, so the build breaks.shellui migratefixes the known cases:It reads the project's own
.razorand.csfiles. It skips the installed components underComponentsPath(update rewrites those) andbin,objandnode_modules. It shows each changed line, and nothing is written without a yes.Migrations, taken from the release notes' upgrade sections:
inputInput.InputVariant.X→InputVariant.Xdate-pickerSelectedDate/SelectedDateChanged/@bind-SelectedDate→Value/ValueChanged/@bind-Value, on<DatePicker>tags only, soCalendaris untouchedtime-pickerSelectedTimeon<TimePicker>paginationOnPageChange→CurrentPageChanged, except on a tag that bindsCurrentPage(that would set it twice)calendarSelectedDateChangedhandlers that take aDateTime(nowDateTime?). Not rewritten, since the handler body may need changes too.Tag rewrites scan to the tag's closing
>outside quotes, so attributes spread over several lines and>inside a quoted value are handled.Checked end to end in a fresh
dotnet new blazorapp:input,date-picker,time-picker,paginationandcalendarwith the local CLI, then wrote a page in the old API. It failed to build.migrate --dry-runshowed the four rewrites and flagged the Calendar handler.--yesin a pipe, nothing was written (exit 1).--yesrewrote the page. After fixing the flagged handler, the app built with 0 errors and 0 warnings, and a second run said "Nothing to migrate".On the demo app it found one real case, the deprecated
Pagination.OnPageChange, which is migrated here.Tests: 540 passing on net8.0 and net10.0, 0 warnings.