Repository navigation
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VXBaAmufjWXbgKvVRnELU8
ryanlewis
added
fix
Claude
Ports the toolchain bump from #464 so govulncheck (GO-2026-6809) passes. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VXBaAmufjWXbgKvVRnELU8
Owner
Author
|
The Generated by Claude Code |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symptom
In a timezone whose daylight-saving change skips local midnight (Santiago, Asunción, Havana, Beirut…), a to-do scheduled or due on that one day is shown a day early. In Santiago, a to-do dated 2026-09-06 prints as
2026-09-05in plain output and--json.things --on 2026-09-06also filters on the 5th, so it matches the wrong rows.Cause
ThingsDate.ToTimeandParseListDatebuilttime.Date(y, m, d, 0, 0, 0, 0, time.Local). When midnight doesn't exist, Go returns 23:00 on the previous day.ThingsDate.StringandAddDaysread the day back from that value, and--on/--from/--tore-encoded it.Fix
Add
model.DayStart, which steps forward to the first hour that is on the requested day.ToTimeandParseListDateuse it. Normal days are unchanged and still resolve to midnight.Tests
TestThingsDateSkippedMidnightandTestParseListDateSkippedMidnightpin the zone to America/Santiago. Both failed before the fix.go test -race ./...passes.make lintcouldn't run in this environment (golangci-lint is built with Go 1.25, below the repo's 1.26.9), so onlygo vetandgofmtwere checked. No command surface changed, so SKILL.md and docs are untouched.Ran as part of a weekly bughunt routine.
Generated by Claude Code