Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an opt-in native Windows service mode to
hbbsandhbbr, and replace the legacy GUI/NSSM installer path with a service-focused x64 installer targeting Windows Server 2016, 2019, 2022 and 2025.The services report readiness after their listeners are available, handle SCM stop/shutdown requests, write rotating per-service logs, and keep their data separate from program files. Normal foreground operation is retained.
Setup runs the services as LocalService with per-service SID access to application data. The relay has read-only key/configuration access and write access to its own logs; it depends on the ID service for key initialization. Setup creates only the standard desktop-client firewall rules, preserves existing rules during ordinary upgrades, and restores changed rule properties on failure.
The x64 programs use the shared MSVC runtime. Each installer build bundles the current Microsoft-signed v14 redistributable, retains a newer installed version, and records the exact source revision. No Node.js, WebView2, NSSM, runtime administrator account, or automatic reboot is required.
Validation completed locally:
The Windows Server 2022/2025 CI run passed on both targets, including install, stop/start, crash recovery, upgrade with key preservation, uninstall with data preservation, and artifact upload. The initial run passed the installation lifecycle but exposed an artifact-upload issue across drive letters; that workflow issue is fixed.
This PR remains draft pending direct Server 2016/2019 validation, reboot-before-login checks, and real-client remote sessions. CI lifecycle coverage does not establish those remaining cases.
This PR contains the Windows deployment feature only. Independent server bug fixes and dependency updates are submitted separately.
Related existing issues
Related Windows deployment reports:
hbbrandhbbs. Setup instructions in Docs conflict with server hard-coded names. #615 (open): inconsistent NSSM/GUI service naming. The new installer consistently creates hbbs/hbbr with descriptive RustDesk display names.These are related deployment reports, not automatic-closing claims. This PR does not claim to fix the independent high-CPU report in #186.