Conversation
githooks/commit-msg exists and correctly calls ci/validate_conventional_commit.sh, but core.hooksPath was never actually configured on any local clone - the hook never fired, which is how fix!(docs)/docs!(licence) (wrong ! position) got committed without ever being caught before push. Adds `mix githooks.install` (git config core.hooksPath githooks) and mentions it in the Readme's Development section. Closes #50. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Adds a discoverable, repo-local way to activate the existing githooks/commit-msg hook so Conventional Commit subject enforcement runs on contributors’ machines (not only in CI), addressing the gap where core.hooksPath was never set by default.
Changes:
- Introduces
mix githooks.install, which configuresgit config core.hooksPath githooksat the repository root. - Updates the Development section in
Readme.adocto instruct contributors to run the new task.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Readme.adoc | Documents how to activate the repo’s git hooks via the new Mix task. |
| app/lib/mix/tasks/githooks.install.ex | Adds a Mix task that sets core.hooksPath to githooks for the current clone. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
bougyman
pushed a commit
that referenced
this pull request
Aug 10, 2026
🤖 I have created a release *beep* *boop* --- ## [0.8.2](v0.8.1...v0.8.2) (2026-08-10) ### Features * add mix githooks.install to activate the repo's git hooks ([#51](#51)) ([9b35472](9b35472)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #50.
githooks/commit-msgexists and correctly callsci/validate_conventional_commit.sh, butcore.hooksPathwas never actually configured on any local clone - the hook never fired, which is howfix!(docs)/docs!(licence)(wrong!position) got committed without ever being caught before push.Adds
mix githooks.install(git config core.hooksPath githooks) and mentions it in the Readme's Development section so it's actually discoverable.Related:
mainnow also requires theTestandValidate Commit Subjectschecks to pass before merge, with no admin override - so even if the local hook is skipped, CI backstops it.Test plan
mix test- 182 passedmix format --check-formatted- cleanmix githooks.installfor real, then fed a malformed subject (fix!(docs): ...) through the now-activegithooks/commit-msghook directly - correctly rejectedasciidoctor -o /dev/null Readme.adocrenders clean🤖 Generated with Claude Code