Skip to content

fix(ci): skip commit-subject validation in the post-merge pipeline - #41

Merged
bougyman merged 1 commit into
mainfrom
issue-40
Aug 10, 2026
Merged

fix(ci): skip commit-subject validation in the post-merge pipeline#41
bougyman merged 1 commit into
mainfrom
issue-40

Conversation

@bougyman

Copy link
Copy Markdown
Member

Summary

Closes #40.

main.yaml's validate job calls ci.yaml as a reusable workflow, running both Test and Validate Commit Subjects post-merge. The commit-subject check only makes sense pre-merge (should this PR be mergeable) - by the time main.yaml runs, the commits are already merged, so re-checking their subjects is meaningless. Test still re-runs post-merge (verifies the actual merge result); commit-subject validation no longer does.

Added a skip_commit_validation workflow_call input on ci.yaml (default false, so its own pull_request/workflow_dispatch triggers are unaffected), and main.yaml's validate job now passes skip_commit_validation: true.

Test plan

  • Both edited workflow files validated with ruby -ryaml
  • Confirmed the if: inputs.skip_commit_validation != true expression safely defaults to running the job for every trigger type that doesn't explicitly pass the input (pull_request, workflow_dispatch) - inputs.skip_commit_validation evaluates to null there, and null != true is true

Validate Commit Subjects only makes sense pre-merge (should this PR be
mergeable) - by the time main.yaml's validate job runs, the commits are
already merged, so re-checking their subjects is meaningless. Test
still re-runs post-merge (verifies the actual merge result); commit-
subject validation no longer does, via a new skip_commit_validation
workflow_call input on ci.yaml.

Closes #40.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings August 10, 2026 00:17

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the post-merge workflow (main.yaml) to avoid re-running commit-subject validation after a PR is already merged, while keeping the reusable CI workflow (ci.yaml) behavior unchanged for its normal pre-merge triggers.

Changes:

  • Add a skip_commit_validation boolean input to the reusable CI workflow (ci.yaml) with a default of false.
  • Gate the “Validate Commit Subjects” job in ci.yaml behind if: inputs.skip_commit_validation != true.
  • Pass skip_commit_validation: true from main.yaml when invoking the reusable CI workflow post-merge.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
.github/workflows/main.yaml Passes skip_commit_validation: true when calling the reusable CI workflow in the post-merge validations job.
.github/workflows/ci.yaml Introduces a workflow_call input and uses it to conditionally skip the commit-subject validation job.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@bougyman
bougyman merged commit 3d00a85 into main Aug 10, 2026
3 checks passed
@bougyman
bougyman deleted the issue-40 branch August 10, 2026 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Validate Commit Subjects should not re-run in the post-merge pipeline

2 participants