Repository navigation
fix(web): settle cancelled camera startup waits - #331
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Camera/sample startup could remain pending after Stop once worker readiness had completed but camera acquisition or video playback had not. Race both startup waits against a per-run cancellation completion, returning false on Stop, replacement, failure or the preparation deadline while retaining late-stream cleanup and presenter ownership checks.
Validation: both parent browser failures reproduced; 77 JS tests, 6 asset controls and 73 real WASM/model browser checks pass. Seven owned local commands are terminal, with no compiler-cache growth. Reuse pinned vendor hardlinks and the existing WASM; preserve 613 prior camera/renderer files, 493 scientific JSON and 42 frozen native artifacts.
Native getUserMedia/video.play work is not cancelled. Physical phone/Safari behavior and operational 80% qualification remain open. Slice 146AQ; source-bound evidence is in docs/receipts/2026-10-21_camera_startup_completion.json. Exact-source CI and the matching public Pages release are verified during delivery.