Repository navigation
feat: About dialog, and the version at the foot of Settings - #79
Merged
Merged
Conversation
There was no way to tell which version was running short of the diagnostics report. Settings now ends with "GitVantage <version>" and an "About GitVantage" link, which opens a dialog with the version, the build kind and platform, a Copy for bug reports, and links to the release notes and source. On macOS the app menu gets "About GitVantage" and "Settings…" (⌘,) as well, with Quit (⌘Q). Nucleus's public menu API can only replace the whole menu bar, so this is the app menu in full: Hide, Hide Others and Services are not in it. The settings list now scrolls in the height the footer leaves it, rather than taking the whole dialog and pushing the footer out. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Raman Gupta <rocketraman@gmail.com>
NativeMenuBar replaces the whole menu bar, so the app menu it built lost Hide, Hide Others and Services. Not worth it for one About item; that needs a way to add to the stock app menu, which Nucleus doesn't expose. The About dialog stays reachable from the foot of Settings. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Raman Gupta <rocketraman@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Not in the macOS app menu. The second commit backs out a first attempt: Nucleus's only public menu API (
NativeMenuBar) replaces the whole menu bar, which lost Hide, Hide Others and Services. Adding an item to the stock app menu needs a hook from Nucleus. Squash on merge.Tests
./gradlew check: 254 tests run, 0 failures; smoke test 13 passed, 1 skipped (macOS only). Footer and dialog checked in a headless KWin session.