Repository navigation
feat(pi): wake actors from Pi Durable 1.4.0's onWake - #367
Merged
Merged
Conversation
|
This PR was not deployed automatically as @eersnington does not have access to the Railway project. In order to get automatic PR deploys, please add @eersnington to your workspace on Railway. |
📟 Pip-Boy ·
|
| package (linux-x64-gnu) | @latest |
base | this PR | Δ vs base | packages |
|---|---|---|---|---|---|
@rivet-dev/pi |
429.8 MB | 429.9 MB | 429.9 MB | −143 B (−0.0%) | 218 (0) |
@rivet-dev/sandbox-adapter |
76.0 MB | 113.8 KB | 113.8 KB | 0 | 1 (0) |
@sandbox-agent/cli-shared |
27.2 KB | 27.2 KB | 27.2 KB | 0 | 1 (0) |
@sandbox-agent/persist-indexeddb |
12.4 KB | 12.4 KB | 12.4 KB | 0 | 1 (0) |
@sandbox-agent/persist-postgres |
12.3 KB | 12.3 KB | 12.3 KB | 0 | 1 (0) |
@sandbox-agent/persist-rivet |
12.2 KB | 12.2 KB | 12.2 KB | 0 | 1 (0) |
@sandbox-agent/persist-sqlite |
12.3 KB | 12.3 KB | 12.3 KB | 0 | 1 (0) |
@sandbox-agent/react |
41.5 MB | 41.9 MB | 41.9 MB | 0 | 15 (0) |
acp-http-client |
6.7 MB | 6.7 MB | 6.7 MB | 0 | 3 (0) |
sandbox-agent |
30.9 MB | 31.0 MB | 31.0 MB | 0 | 8 (0) |
🧹 Rust dependencies
Skipped: this PR doesn't change any Rust code or dependencies.
🦀 Binaries
Skipped: this PR doesn't change any Rust code.
⏱ Timing
| job | wall time | slowest step |
|---|---|---|
changes |
18s | checkout · 13s |
zizmor |
14s | checkout · 9s |
footprint |
3m05s | Run pnpm --dir sandbox-agent install --frozen-lockfile · 1m28s |
⏭ native · ${{ matrix.platform }} |
— | skipped |
⏭ self-test |
— | skipped |
⏭ hygiene |
— | skipped |
report |
34s | setup-node · 16s |
🔭 Full CI trace for this commit
One OpenTelemetry trace of CI and Pip-Boy for f55c2fc: every job and step, with the sizes above attached. Run after CI finishes.
pnpm install --frozen-lockfile --filter 'pipboy...'
pnpm --filter pipboy pipboy trace --sha f55c2fc5c1a50e52b93bea9d26545006a988cbe8Add --otlp <url> to send it to any OTLP/HTTP collector.
Agent instruction: From a rivet-dev/agents checkout, run the commands above, then read the trace file the last command prints. List the slowest jobs and steps and explain where CI time went.
eersnington
marked this pull request as ready for review
October 27, 2026 02:38
eersnington
force-pushed
the
feat/pi-durable-1.4
branch
from
October 27, 2026 03:18
2295eb8 to
7f9ee92
Compare
eersnington
force-pushed
the
feat/pi-durable-1.4
branch
from
October 27, 2026 03:38
7f9ee92 to
f55c2fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pi Durable 1.4.0 runs generation retry backoffs and deferred polls as durable
sleepingtasks, and reports when the Harness next needs a process throughHarnessOptions.onWake.pi()used to find those waits by reading Pi's private task checkpoints (phase: "retry"withuntil,phase: "poll"withpollAt). Under 1.4.0 those tasks aresleeping, which that code did not handle.pi-durable,chordpeers^1.0.0^1.4.0pi-telemetry^1.4.0onWake, every sleeping taskonReportsession_failed; passesReportInfoto the appchore(pi): require Pi Durable 1.4.0: peers,pi-telemetrypeer (the action types reference it),checkpointWhenon everydefineDoc(now required),onReport(error, info).fix(pi): wake sleeping tasks through Pi Durable's onWake:wakeActor()replacesbusyState,waitDeadline, andwatchBusy.until <= now, and callsonWakeonly when the value changes. A wake that fires early re-readsharness.wake()and schedules again.c.schedule.atfails, the actor stays awake and resumes Pi on a timer.harness.wake().activeand rechecks when the wake value changes, because Pi can settle that value after the last commit.fix(pi): reopen Pi only after a failed session: 1.2.0 and later report much more than storage failures throughonReport.Opening a stored actor migrates its SQLite to Pi Durable schema version 2. 1.3.0 and earlier cannot open it, so an actor cannot roll back past this release.