Conversation
* feat: replace travis with github actions --------- Co-authored-by: dvinakur <dvinakur@netflix.com>
|
Coverage is 88.863% — node26 into master. No base build found for |
| }, | ||
| "license": "MIT", | ||
| "engines": { | ||
| "node": ">=22.0.0" |
There was a problem hiding this comment.
Can we jump 24 instead of 22? Want to be consistent and seeing that's what we did here: Netflix/nerror#21 (comment)
There was a problem hiding this comment.
The reason why I decided to leave 22 that this version is still in maintenance. I did the same for restify.
| * @public | ||
| * @function createClient | ||
| * @param {Object} options an options object | ||
| * @param {Object | String} options an options object or URL string |
There was a problem hiding this comment.
Why do we need to add String as an accepted type?
There was a problem hiding this comment.
I changed the JSDoc because the code already supports both forms:
createJsonClient({ url: 'https://example.com' })
createJsonClient('https://example.com')
normalizeOptions() explicitly handles strings by converting them to { url: string }, so documenting options as only {Object}
was inaccurate.
This is documentation only. It does not change runtime behavior or break callers.
There was a problem hiding this comment.
Do you think we need to leave this type without changes?
There was a problem hiding this comment.
Nice catch, I think this is good then.
3 participants
Summary
Migrates restify-clients toward Node.js 22/24/26 support.
Changes
Updates supported Node runtime to >=22.0.0.
Updates release workflow Node version to Node 22.
Upgrades test Restify dependency to 12.0.0-rc.0.
Updates Restify-backed tests for Restify 12 APIs:
Replaces deprecated Node APIs:
Replaces uuid dependency usage with native crypto.randomUUID().
Removes direct uuid production dependency.
Adds URL behavior coverage for:
Replaces weak embedded TLS test key with shared Node 26-compatible TLS fixtures.
Moves external HTTPS timing test to a local TLS server for deterministic test behavior.
Updates migration plan with current Node 26 status, resolved deprecations, and production audit notes.
Breaking Changes
Verification
NODE_OPTIONS=--throw-deprecation make test