Skip to content

CHORUS: the Rytm send effect joins the library - #1257

Open
stigmagit wants to merge 7 commits into
repeat98:mainfrom
stigmagit:module/rytm-chorus-library
Open

stigmagit wants to merge 7 commits into
repeat98:mainfrom
stigmagit:module/rytm-chorus-library

Conversation

@stigmagit

Copy link
Copy Markdown
Contributor

CHORUS (#1060) moves from _submissions/ into the Analog Rytm MKII library. It is the first of the base's send effects to be served. The site has built Rytm sets on the Modwerk base since #1085, so a set with CHORUS plans on the base's send-bus variant (0cdf0343, from #1097).

  • What changes:
    • sdk/analog-rytm-mkii/modules/_submissions/chorus moves to modules/chorus. The source is unchanged (source sha256 6d8a8155…).
    • Two rytm-emu captures of build CH02, recorded in media/capture.json: the SEND page (behind AMP) and the SEND FX page with CHORUS. They come from rytm-emu 2ac0f1f, the pinned revision, which reaches SEND FX: on the FX track, the SRC key (DELAY there) switches between DELAY and SEND FX.
    • The tutorial goes in tests.documentation and presentation.usage. The release notes go in src/community/module-changelogs/analog-rytm-mkii-chorus.json. TESTING.md gains the rytm-emu result and a library section.
    • The source-only package chorus-0.1.0-experimental-os1.74.elemod (70be8884…) is built by scripts/build-elemod-isolated.sh in modwerk-source-tools. It is pinned in sdk/imports/elekloader-chorus-2026-11-04.json (needs_core: "0.7") and recorded in sdk/imports/chorus-2026-11-04.json.
    • CHORUS is added to the module list in sdk/analog-rytm-mkii/modules/README.md, to library-parity.test.ts and to a plan test in digi-build.test.ts.
    • digi-build.test.ts's send-bus test now plans the catalogue's own CHORUS instead of a stand-in record.
    • rytm-base.test.ts's local whole-build part takes the send effects the catalogue pins and builds only the others from MODWERK_RYTM_FX. That avoids a second CHORUS beside the pinned one.
  • How I checked it (the owner's stock OS 1.74, sha256 cb0f99d6…e123), after merging main at eaaf60ca:
    • node scripts/verify-elemod-release-exports.mjs: 39 committed exports reproduce, CHORUS's among them. Improvement: the Rytm base gives send effects the sequencer's time, SRC + YES random, MISSING left with FUNC + A, a 32 KB work area #1097's change to modwerk/fx.h (an 8192-word work area and the clock) leaves CHORUS's package byte-identical. CHORUS uses a 16 KB work area, within the base's 32 KB.
    • Captures: build CH02 links this package on send-bus 0cdf0343. Both screens are pixel-identical to those of CH01, which was built on the earlier send-bus 0c92aa45.
    • rytm-base.test.ts with MODWERK_RYTM_STOCK set: through the site's prepareBuild and buildWithLock, CHORUS alone and CHORUS with Loop Sync build on send-bus 0cdf0343 from the plain set's lockfile. Every one of the plain set's storage fields keeps its place.
    • npm run module:doctor -- chorus: every integration point is green, including the board claim (analog-rytm-mkii/chorus, until 18 November 2026).
    • npm run pr:ready: Ready.
    • On a unit: test build MB02 (29 October 2026), with the same source built locally. As the author reported: "tout marche". This exact package has not run on a unit.
  • FLANGER and PHASER follow in their own PRs. Each touches the same line of the module list and of library-parity.test.ts.
  • What the guides lacked: the module's README and TESTING.md said rytm-emu does not reach SEND FX. It does on the pinned revision, through the SRC key on the FX track. Both now say so, with the capture plan in media/capture.json.

🤖 Generated with Claude Code

stigmagit and others added 7 commits November 4, 2026 12:10
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…s and library listing

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Built by scripts/build-elemod-isolated.sh in modwerk-source-tools (660763bd); it reproduces
with package-elemod-recipe.mjs --check, and the 35 committed exports reproduce from the same build.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…brary

# Conflicts:
#	sdk/analog-rytm-mkii/modules/README.md
#	src/devices/library-parity.test.ts
#	src/engine/elekloader/digi-build.test.ts
…ue pins and builds only the others

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant