Skip to content

ENG-13516: Normalize component identifiers in docs search - #7647

Open
carlosabadia wants to merge 3 commits into
mainfrom
carlos/eng-13516-normalize-component-search
Open

carlosabadia wants to merge 3 commits into
mainfrom
carlos/eng-13516-normalize-component-search

Conversation

@carlosabadia

@carlosabadia carlosabadia commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Normalize component searches such as rx.button, rx.input, and compound names so the relevant component documentation ranks first.

Adds regression tests for normalization and unchanged search behavior. Validated with 173 passing shared-site tests and browser checks against the production build.

@carlosabadia
carlosabadia requested a review from a team as a code owner October 23, 2026 09:43
@carlosabadia carlosabadia added the skip-changelog For doc/internal changes label Oct 23, 2026
@linear-code

linear-code Bot commented Oct 23, 2026

Copy link
Copy Markdown

ENG-13516

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Tip: Get a Slack DM when cubic finishes reviewing your PRs. Connect Slack

View guided diff | Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no blocking issues remain.

Summary

Normalizes complete component names such as rx.button and rx.radio_group before sending searches to Algolia.

  • Component searches turn rx.* names into words that match docs titles.

Reviews (3) · Last reviewed commit: "Cover published docs search normalizatio..." · Reviewed by Greptile

Comment thread tests/units/reflex_site_shared/test_algolia.py Outdated

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 5 files (changes from recent commits).

Reply with feedback, questions, or to request a fix.

View guided diff | Turn on auto-fix | Re-trigger cubic

Comment thread tests/units/reflex_site_shared/test_algolia.py
@codspeed

codspeed Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

1 warning

⚠️ 16 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

✅ 148 untouched benchmarks


Comparing carlos/eng-13516-normalize-component-search (c095935) with main (a9b6613)

Open in CodSpeed

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog For doc/internal changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant