Repository navigation
Conversation
A bar in the colour of the line, green or red, marks an inserted or a deleted line in place of + or -. The bar takes the same two cells, so the columns, the clicks, and the wrap do not change. The setting diff_signs = true gives the signs back. The review text for the agent keeps + and -. Fixes #3
Owner
Author
|
Merged into master through #10. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3. Stacked on #5.
Change
▌in the colour of the line (ANSI green or red) marks an inserted or a deleted line, in place of+or-. This is the style of herdr-reviewr.diff_signs = truegives+and-back, for users who want marks that do not depend on colour.+and-.VENDORED.mdlists it.Tests
diff.TestMarks: the exact screen lines with the bar and with signs, in the unified and the split layout; the colour of each mark (red for a delete, green for an insert); the bar with a scroll to the right (▌…cdefgh); the review text keeps+and-in both cases.tui.TestDiffSigns: the screen of rexdiff shows the bar by default, and+/-with{"diff_signs": true}.TestParseConfigacceptsdiff_signs.diff_signs.