Remove illuminate/container patch scaffolding - #389
Merged
Conversation
rector/rector-src switched its DI container from illuminate/container to entropy/entropy, so the Illuminate container patch it used to declare is gone. Drop the now-dead patch opt-in here: the symplify/vendor-patches dev dep, the extra.enable-patching flag, and the cweagans/composer-patches allow-plugin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rector/rector-srcswitched its DI container fromilluminate/containertoentropy/entropy(rectorphp/rector-src#8362), so the Illuminate container patch it used to declare is gone.This drops the now-dead patch opt-in that this package carried only to apply that upstream patch:
"require-dev": { - "symplify/vendor-patches": "^11.5", }, - "extra": { - "enable-patching": true - }, "config": { "allow-plugins": { - "cweagans/composer-patches": true, } }No patch is declared in this repo and none remains upstream, so the scaffolding is pure dead weight.
Note
Green CI here depends on rectorphp/rector-src#8362 being merged first — this package tracks
rector/rector-src: dev-main, which still ships the (now unpatched) Illuminate container until that PR lands.