Repository navigation
http: let derived classes inherit HtmxResponseAttribute - #105
Merged
Merged
Conversation
HtmxResponseAttribute was declared with AttributeTargets.All and Inherited = false, so it had no effect on a base controller or page model and could be applied where it does nothing. Restrict the attribute to classes and methods and make it inherited. Allow one attribute per target: with AllowMultiple = true, MVC executed the inherited attribute after the derived one, so the base class headers won. The attribute of a derived class now replaces the inherited one. Applying the attribute to other targets or more than once per target is now a compile-time error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.