Repository navigation
perf: coalesce redundant transcript paints during output bursts - #506
Open
raiseCatError wants to merge 1 commit into
Open
raiseCatError wants to merge 1 commit into
raiseCatError wants to merge 1 commit into
Conversation
This was referenced Oct 25, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Output bursts repaint and rewrap the transcript for every PTY chunk, making a 10,000-line command take ~29 seconds in the baseline workload. Coalesce only output-triggered paints within one display tick; keep parsing, terminal queries, passthrough and input/prompt/resize frames synchronous.
Pending mouse events resolve against the last displayed viewport; active selection drags retain synchronous output painting so release cannot copy an unseen redraw. The snapshot retains only visible rows. No shell bytes are discarded and no queue/input approval semantics change.
Measured on Apple M2 / 8 GiB / macOS 27 / Node 26.12, built CLI with disposable config/services:
Independent static review approved after pointer/selection findings were fixed. Focused production-path regressions pass. Full canonical
npm run verifypassed with two workers, private short T7 fixtures and explicit xterm-256color/truecolor capabilities (NO_COLOR unset). No tests excluded or assertions changed. Four-worker completion-helper failure and an invalid-color cancelled attempt are documented in the evidence. Existing Arcade disposal TODO and intermittent macOS read issue are not claimed fixed.Physical Ghostty/Zed QA: NOT RUN. Check large Unicode output while typing, selection/copy during live redraw, detached scrolling/resizing, Ctrl+C/Ctrl+Z, fullscreen entry/return, NO_COLOR and Reduced Motion. Keep the issue open pending real terminal validation.
Refs #505
Do not merge automatically.
Exact-head CI:
792fb1ad7e687cc0e2e4e93af58029e59409b146passed macOS/Ubuntu shards, Quality and Node 22 compatibility; aggregate CI green. Fedora/timing jobs were skipped by workflow conditions. CI run. PR remains unmerged.Environment clarification: t7run supplies
NODE_COMPILE_CACHE=/Volumes/T7Tmp/ai-dev/caches/node-compile; the original before/after runs inherited it. No OS-cache purge or true cold-start claim. The one four-worker completion capture failure returned zero after ~2.45 s, consistent with a helper deadline under load; its root cause is not proven. Focused and full two-worker reruns passed unchanged.