Updated documentation on housing and building sliders - #361
Open
jort-wolda wants to merge 2 commits into
Open
Conversation
mabijkerk
reviewed
Aug 21, 2026
| title: Priority in building and housing inputs | ||
| --- | ||
|
|
||
| The housing and building stock, insulation and behaviour inputs (introduced in [quintel/etsource#3470](https://github.com/quintel/etsource/pull/3470)) update a lot of shared graph state: typical heat demand attributes, useful demand `preset_demand`, number of units, roof surface for PV, and more. Because ETEngine applies inputs one after another (see [Priority](inputs#priority) for the general mechanism), the **order** in which these inputs run matters. Running them in the wrong order silently produces incorrect results rather than an error. |
Member
There was a problem hiding this comment.
I would not refer to a pull request in the documentation. Additionally, this phrasing is a bit weird "a lot of shared graph state"?
mabijkerk
reviewed
Aug 21, 2026
|
|
||
| If the user selects a non-default weather year, this scales `preset_demand` for space heating and cooling using temperature/degree-day factors derived from that weather year, and marks `AREA(weather_curve_set)` as non-default. This must run after stock changes so it scales correctly. | ||
|
|
||
| 4. **`priority = 1` — insulation** |
Member
There was a problem hiding this comment.
Why is there a 4. here and a 5. below?
mabijkerk
reviewed
Aug 21, 2026
|
|
||
| This order is also documented as a comment at the top of each of the relevant `.ad` files in etsource, so it stays visible to anyone editing them directly. | ||
|
|
||
| ### Weather year overrides outdoor temperature |
Member
There was a problem hiding this comment.
I would maybe also add a sub header describing the role of user_curves and how a custom temperature curve comes in:
weather/air_temperature:
type: temperature
display_group: weather
reduce:
as: temperature
sets:
- flexibility_outdoor_temperature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Updates the documentation based on the new input sliders for buildings and residences.
Implemented changes
Related
Goes with pull requests:
Checklist