[rasterio] Allow WarpedVRT to take DatasetWriter - #16156
Open
jack-volantautonomy wants to merge 1 commit into
Open
[rasterio] Allow WarpedVRT to take DatasetWriter#16156jack-volantautonomy wants to merge 1 commit into
jack-volantautonomy wants to merge 1 commit into
Conversation
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The aim of this PR is to change the typing so that the src dataset provided to
WarpedVRTcan take arasterio.io.DatasetWritertoo. This is because a DatasetWriter also has the read methods required on it so is a suitable parameter type.Not sure if this is the most correct fix and if we should make use of protocols instead but should do the job and might just be the fix we need.