Repository navigation
Keep the GitHub token out of git command lines - #749
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #749 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 356 366 +10
Branches 12 12
=========================================
+ Hits 356 366 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Member
Author
|
I am rotating the auth token after this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The worker embedded
GH_AUTHin the clone URL and the upstream remote URL. When a git command failed, theCalledProcessErrortraceback printed the full command line, token included, into the logs. This happened during the cabotage cutover, so the current token needs to be rotated separately.The token is now supplied through a git credential helper that reads
GH_AUTHfrom the environment when git asks for it. The clone and remote URLs are plain, so the token no longer appears in command lines, in.git/config, or in tracebacks. Pushes by cherry_picker go through the same helper.Adds a test that runs
setup_cpython_repowith a sentinel token and asserts it is absent from every git command.