Repository navigation
Conversation
When IGzipFile.__init__ does not set self.compress, GzipFile compresses with zlib instead, and the igzip tests still passed.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
IGzipFile.__init__()doesn't setself.compress,GzipFilecompresses withzlibinstead, and no test checked for that. The new test compares the deflate data thatIGzipFilewrites at each level with the output ofisal_zlib.compressobj(), byte for byte.To test it, I removed that line, and in another copy, always passed level 2 to
compressobj(). The old tests intests/test_igzip.pyand the gzip compliance tests pass in both cases. The new test fails at all four levels with the first change, and at levels 0, 1, and 3 with the second.The test writes 30,000 bytes. They fit in the write buffer that
GzipFilehas on Python 3.12 and later, soIGzipFilecompresses them with onecompress()call, like thecompressobj()call it is compared with.This PR changes only tests, so it has no CHANGELOG entry.
Checklist