Repository navigation
Check the exception type in test_failure of IgzipDecompressor - #305
Merged
rhpvorderman merged 1 commit intoOct 28, 2026
Merged
Conversation
pytest.raises(Exception) also passes on the SystemError that Python raises when decompress() returns NULL without setting an exception.
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_failureusespytest.raises(Exception), which also passes on theSystemErrorthat Python raises whendecompress()returnsNULLwithout setting an exception. CPython'stest_bz2, where the test comes from, also usesException. This PR checks forigzip_lib.IsalError, whichdecompress()raises for invalid data.To test it, I removed the
isal_inflate_error(err)call for invalid data indecompress_buf(). The old test passes, and the new one fails withSystemError.This PR changes only tests, so it has no CHANGELOG entry.
Checklist