Repository navigation
Test threaded writes with blocks larger than 32 KiB - #302
Merged
rhpvorderman merged 1 commit intoOct 28, 2026
Merged
Conversation
With 8 KiB blocks, the last 32 KiB of the previous block is the whole block, so the tests could not tell whether the writer took the dictionary from the end or the start of it.
Collaborator
|
Yes. It is indeed good to test that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
igzip_threadedcompresses each block with up to 32 KiB from the end of the previous block as a dictionary (previous_block[-DEFLATE_WINDOW_SIZE:]).test_threaded_writeuses 8 KiB blocks, so the end and the start of the previous block are the same bytes. When I changed the slice to[:DEFLATE_WINDOW_SIZE], all tests intests/test_igzip_threaded.pystill passed, but a file written with 64 KiB or 1 MiB (the default) blocks failed the CRC check when read back.This PR also runs
test_threaded_writewith 64 KiB blocks. With the changed slice, all six new cases fail. Together they take about 0.1 s.This PR changes only tests, so it has no CHANGELOG entry.
Checklist