Repository navigation
Check the flags byte for FNAME in test_compress_infile_out_file_no_name - #301
Merged
rhpvorderman merged 1 commit intoOct 28, 2026
Merged
Conversation
The test checked byte 4, the first byte of MTIME. The flags are in byte 3.
Collaborator
|
Ah. Such an unfortunate mistake. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test checks
output[4] & gzip.FNAME, but byte 4 is the first byte of MTIME, and the next line already checks that MTIME is 0. So that check can't fail. The flags are in byte 3.To test the fix, I made
-nkeep the file name in the header. The test passes ondevelopand fails with this PR.This PR changes only tests, so it has no CHANGELOG entry.
Checklist