Repository navigation
Fix -0 and --fast in the igzip command line interface - #300
Merged
Merged
Conversation
main() chose the level with `args.compresslevel or _COMPRESS_LEVEL_TRADEOFF`, so level 0 fell back to level 2. Set the default level in the argument parser instead.
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
python -m isal.igzip -0and--fastcompress at level 2.main()picks the level withargs.compresslevel or _COMPRESS_LEVEL_TRADEOFF, and 0 is falsy. For example, on the first 200,000 bytes of the FASTQ file intests/data/test.fastq.gz,-0and-2both give 96,708 bytes. With this PR,-0gives 129,336 bytes with the XFL byte set to 4 (fastest), and the other levels give the same output as before.This PR sets the default level with
set_defaults()in the argument parser.test_compress_stdin_stdoutnow also checks the XFL byte. Ondevelop, that check fails for level 0.Checklist