Repository navigation
chore: replace ESLint with oxlint - #24
Merged
Merged
Conversation
oxlint runs the correctness rules with no plugins to configure, and it replaces 3 ESLint packages with 1. The config fails the lint target on any finding and keeps ignoreRestSiblings, so a destructure can still drop a key.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the ESLint setup from #23 with oxlint 1.88.0.
This PR makes the following changes:
eslint,@eslint/js, andtypescript-eslint, and addsoxlint.packages/iterward/eslint.config.jswithpackages/iterward/.oxlintrc.json.lintscript tooxlint. The root script, thetypechecktarget, and the CI step stay the same.The config sets the
correctnesscategory toerror, so CI fails on any finding. oxlint reports warnings by default, which don't fail the run. The config also keepsignoreRestSiblingsonno-unused-vars, soconst { _, config, run, ...inputs } = acan still drop keys.The ESLint config turned off
no-explicit-anyand allowed emptycatch {}blocks. The oxlint config needs neither setting, because oxlint'scorrectnesscategory doesn't include those rules.oxlint lints the
.ts,.mts, and.jsfiles and skipsdist/through.gitignore.