Implement registry version check script - #786
Conversation
83fb1c3 to
7c1e2cc
Compare
|
This is cool - two things come to mind:
|
|
Yeah, I agree. I don't have a specific policy in mind but directionally I'm on board. To what degree should that be encoded into this script's report? We could augment this with more data than it currently gives. |
|
Also, we could extend this with a planner that makes it more obvious whether the discovered versions will even work together and suggest a batch. Something like:
For this batch, this would have discovered the 14 packages that work without me having to do a separate manual triage:
...this doesn't help with what you're describing, but maybe we can re-think this script such that it's a more useful swiss-army-knife for helping get the package sets updated with the best options when it can't be done automatically due to breaking changes. |
I to get us a good glance we could have:
Also I think we could be running this in a weekly cronjob thing in the Registry repo, opening an issue/PR if it finds something |
|
d283822 has some followups that address your points:
Tried it out with a live run against package set |
|
Latest commit is a prototype, still hacking on it a little. But as I was working on the version check script, I realized we could be doing a lot more automatically — and still safely — to update the package sets. Our current automatic upgrade is basically just "try all new packages in the last 24hrs, and if any fail, go sequentially and only include ones which succeed." Very naive, and if a package doesn't work in its 24h window for whatever reason it is never retried — even if it would work later on (such as a dependency finally upgrading). So the new prototype implements one shared planner that can be used by both the package set updater and the version check workflow. Any version of a package that's already in the set which is newer than what's in the set is eligible for any new plan, plus recently uploaded packages even if they've never been in the set. We restrict to a single compiler version but otherwise ignore ranges. We still try all packages first, but then we do bounded best-first latest/intermediate/current searches. The package set updater, if it is capable of finding a nonempty addition/upgrade plan, can just submit it. If it finds removals, downgrades, etc. then we can have that notify trustees for action, but it will never be automatically done. |
2a50471 to
e82da1b
Compare
Greptile SummaryThis PR adds a
Confidence Score: 5/5The PR is safe to merge. The new checker runs entirely read-only, the planner extraction is well-tested, and the API switch to atomic-only semantics is a deliberate, clearly-reasoned design choice with matching spec updates. The core logic reuses heavily-tested planner infrastructure, the report rendering has no mutable side-effects, the workflow correctly guards issue creation with hashFiles, and the atomic API change aligns the server behavior with the offline planning model described throughout the PR. Files Needing Attention: .github/workflows/package-set-version-check.yml — consider whether a periodic schedule trigger should be added alongside workflow_dispatch.
|
| Filename | Overview |
|---|---|
| scripts/src/PackageSetVersionChecker.purs | New script: runs the planner against every registry version newer than the latest package set, then renders a Markdown report with compile-verified payloads. Logic is clean and correctly delegates to shared planner/updater helpers. |
| .github/workflows/package-set-version-check.yml | New workflow: triggers only on workflow_dispatch (manual). Correctly guards issue creation with hashFiles check, but lacks a schedule trigger for periodic automated reporting. |
| app/src/App/PackageSetPlanner.purs | New module: extracts the five-phase compile-guided planner and removal analysis from the updater into a shared app/ module. Implementation is well-structured with clear invariants. |
| app/src/App/Effect/PackageSets.purs | Removes UpgradeSequential constructor, upgradeSequential function, and orderChanges helper — simplifying the effect to atomic-only semantics. |
| app/src/App/API.purs | Switches packageSetUpdate from upgradeSequential (partial success) to upgradeAtomic (all-or-nothing), aligns commitMessage call to use full changeSet instead of succeeded subset, and fixes log codec to use packageSetOperationCodec. |
| app/src/App/GitHubIssue.purs | Simplifies signPackageSetIfTrustee to take only the operation (not the inner data), and switches readOperation to use packageSetOperationCodec — keeping encoding consistent with the new atomic API contract. |
| app-e2e/src/Test/E2E/Scripts.purs | Updates runPackageSetUpdaterScript to wire PackageSets, Storage, and RESOURCE_ENV effects that the refactored updater now requires; exposes workdir and cache in the shared RegistryScriptSetup record. |
| nix/overlay.nix | Adds package-set-version-checker to the scripts map so it is built and exposed as a Nix flake app via nix run .#package-set-version-checker. |
| SPEC.md | Fixes a syntax typo in the JSON example and rewrites Section 6.3 to accurately describe the new atomic planner-first approach, constraints, and the trustee manual-intervention path. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[workflow_dispatch] --> B[nix run package-set-version-checker]
B --> C{Latest package set?}
C -- No --> D[Log warning, exit 0, no file written]
C -- Yes --> E[Read all metadata + manifests]
E --> F[plannerCandidates with empty additionSeeds]
F --> G[planUpgrades: phases 1-5\nprobe budget 60]
G --> H[analyzeRemovals\ntotal budget 100]
H --> I[renderReport: Markdown]
I --> J[Write version-check.md]
J --> K[Upload artifact]
K --> L{hashFiles != empty?}
L -- No --> M[Skip issue creation]
L -- Yes --> N[gh issue create]
subgraph PackageSetPlanner
G
H
end
subgraph PackageSetVersionChecker
E
F
I
J
end
Reviews (6): Last reviewed commit: "Automate compile-guided package set upda..." | Re-trigger Greptile
1a035ef to
7fdca95
Compare
Adds a compile-guided planner for package set upgrades in a dedicated module. The planner probes root selections — packages already in the set plus proposed additions, each closed over the absent dependencies they require — with exact whole-set compiles, and repairs failures greedily: it attributes compiler errors to the exact selected versions, drops implicated roots, rescues over-dropped roots, falls back to intermediate versions, and probes coordinated interaction components together. The verified payload is always exactly the change set accepted by its most recent successful compile probe. Blocked upgrades are analyzed for compile-verified removal closures that Registry Trustees can review. The package set updater plans against the latest package set and submits the exact verified payload as one atomic operation, which the server recompiles before publishing. The version check script renders a Markdown report of pending upgrades: what is eligible for automatic submission and what requires manual intervention, with ready-to-submit payloads and compiler evidence. A manually-dispatched workflow generates the report and opens an issue. Amp-Thread-ID: https://ampcode.com/threads/T-019fc447-b7d9-7773-b47a-9b1dee18cb3b
7fdca95 to
e132ffc
Compare
Closes #426 by adding a
.#version-checkscript to report registry versions newer than the versions in the latest package set. This reuses the package set updater candidate traversal instead of being brand-new.I ran the script against package set
77.13.1and found 19 pending versions. Not all of them can compile together, but 14 of them do, and that's submitted as purescript/registry#560.Five versions were intentionally left out:
barlow-lens@1.0.0breaksmorello@0.4.0, which uses the old Barlow API and declares<0.10.0.elmish@0.14.0breakselmish-hooks@0.11.0; meanwhile,elmish-html@0.12.0requires Elmish 0.14, so neither Elmish candidate can move until the dependent packages are compatible.hyrule@2.4.0removes modules still imported bybolson@0.3.9,deku@0.9.24, andocarina@1.5.4.node-child-process@12.0.0changes the exit API and breaksdotenv@4.0.3andnode-execa@5.0.0.So this is the point of the script: surface upgrades that automatic daily updates could not accept so maintainers can identify and submit a compatible coordinated batch.