Skip to content

Describe the sentence-length Default in Present Tense in the Scripts README - #3621

Merged
ptr727 merged 1 commit into
developfrom
feature/3531-promotion-fix-readme
Oct 29, 2026
Merged

ptr727 merged 1 commit into
developfrom
feature/3531-promotion-fix-readme

Conversation

@ptr727

@ptr727 ptr727 commented Oct 29, 2026

Copy link
Copy Markdown
Owner

Copilot's review of promotion PR #3619 raised a present-tense nit on scripts/README.md. The sentence describing the sentence-length default told the rollout history. This drops that history and states the current condition.

The same review also noted docs/fleet-map.md. That text is a dated decision record, whose content is the history, so it stays as written.

🤖 Generated with Claude Code

…README

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings October 29, 2026 17:43
@coderabbitai

coderabbitai Bot commented Oct 29, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ptr727

ptr727 commented Oct 29, 2026

Copy link
Copy Markdown
Owner Author

A recorded local strict-review pass covers head 6033c5c1422a4d3882019fa67e542f7483e0995d, the content this pull request carries at that commit against develop, and it recorded 0 findings.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain, and the documentation now accurately describes the sentence-length check as a default rule.

No open issues 🎉

What changed in this PR

Updates scripts/README.md to describe the sentence-length default in present tense, reflecting its current behavior without rollout history.

Changes:

  • Removes historical wording about the rule being opt-in.
  • States that the tree has no over-cap sentences.
  • Documents that the rule runs as a default check.
File Description
scripts/​README.md Rephrases the sentence-length documentation to reflect its current default behavior.

Review effort: Lite

@codecov

codecov Bot commented Oct 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.60%. Comparing base (8111800) to head (6033c5c).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3621   +/-   ##
========================================
  Coverage    81.60%   81.60%           
========================================
  Files           26       26           
  Lines         9070     9070           
========================================
  Hits          7402     7402           
  Misses        1668     1668           
Flag Coverage Δ
python-3.13 81.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ptr727
ptr727 merged commit 487deaa into develop Oct 29, 2026
14 checks passed
@ptr727
ptr727 deleted the feature/3531-promotion-fix-readme branch October 29, 2026 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants