Fix pthread_t initialization issues in testThreads.c and libxml2 - #88
Open
SoftwareRat wants to merge 2 commits into
Open
Fix pthread_t initialization issues in testThreads.c and libxml2#88SoftwareRat wants to merge 2 commits into
SoftwareRat wants to merge 2 commits into
Conversation
Added a patch for pthread_t issue in testThreads.c.
Replaced initialization of tid array with memset to ensure proper memory clearing.
zeldin
reviewed
Aug 16, 2026
Member
There was a problem hiding this comment.
Huh. The patch is applied with -p1, and yet there is no filename given in the patch file. How is that supposed to work?
Also, I can't find any file in libxml2-2.7.8.tar.gz that contains this exact code. There is similar code in testThreads.c, but it is lacking the #if present in this patch...
If if acually is testThreads you are trying to alter, then
tid[i]will be overwritten bypthread_createimmediately afterwards, so there is no need to initialize any part of it. The assignment can just be removed.- That is a testcase, do we even run them?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses a compatibility issue with
pthread_tinitialization inlibxml2for modern toolchains. The main change ensures that thread IDs are properly zero-initialized, and the patch is now applied during the build process.Thread initialization fix
patches/libxml2-2.7.8-pthread.patchto replace the assignment of(pthread_t) -1withmemsetto zero-initializepthread_tvariables, improving compatibility with modern compilers.Build script update
scripts/012-libxml2-2.7.8.shto apply the pthread patch automatically during the build, ensuring the fix is consistently used.