Repository navigation
fix(auth): CoinPay binding in app_metadata, not user_metadata - #343
Merged
Merged
Conversation
…-writable user_metadata
user_metadata can be set by any signed-in user via auth.updateUser({ data }),
so a user who learned a victim's CoinPay sub could stamp it on their own
account and receive the victim's next CoinPay login (GoTrue lists newest
first). The binding now lives in app_metadata (service role only). The two
existing CoinPay accounts were backfilled on prod before deploy.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ThreatCrush Security Scan17 finding(s) MEDIUM: 13 | LOW: 4
Snippets are redacted; ThreatCrush never prints matched credential material. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CoinPay sign-in already binds accounts by sub (never by the unverified email, since #273), but it read the binding from
user_metadata.coinpay_sub, which every signed-in user can write withauth.updateUser({ data }). Someone who learned a victim's CoinPay sub could stamp it on their own account and, since GoTrue lists newest users first, receive the victim's next CoinPay login.app_metadata.coinpay_sub(service role only); new CoinPay accounts get it at creation.🤖 Generated with Claude Code