Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
aik099
force-pushed
the
executable-path
branch
from
October 24, 2026 16:26
a36bc94 to
4aac960
Compare
Author
|
The 4 integration failures ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Playwright can launch a browser binary it doesn't manage through the
executablePathlaunch option, but there was no way to set it from PHP. That's needed for Chromium-based browsers that aren't a Playwright channel, such as Brave or a locally built Chromium.This picks up #101 by @feder-cr, which was closed when its fork was deleted, and adds the tests asked for there.
Updates:
BrowserBuilder::withExecutablePath()sets theexecutablePathlaunch option;PlaywrightConfig::$executablePath,PlaywrightConfigBuilder::withExecutablePath()andPW_EXECUTABLE_PATH, applied inPlaywrightClient::createBrowserBuilder()the same way aschannel; an explicit setter call wins over the config;docs/guide/browsers.md.When it isn't set, nothing is added to the launch payload.
Tested by hand with Brave 155 on macOS through playwright-mink, which ran the Mink driver test suite in it.
🤖 Generated with Claude Code