DateTime::__(un)serialize Improve the examples, add an Error warning, amend method names in the Example section - #4661
Merged
Merged
Conversation
PhilDaiguille
approved these changes
Jul 8, 2025
PhilDaiguille
left a comment
PhilDaiguille
left a comment
Contributor
There was a problem hiding this comment.
i think it's correct
lacatoire
approved these changes
Feb 2, 2026
Member
|
LGTM - Comprehensive improvement: fixes method names, adds proper examples, documents error conditions, fixes return type. |
Member
|
@mmalferov could you rebase ? |
I think an explicit reference to calling the parent constructor better reflects the essence of the method's work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.