Repository navigation
Conversation
…ploy Deploy.s.sol checked only the permanent values. Without TEST_DEPLOY it now also requires 100 PEN (the smallest migration) <= PER_RELEASE_CAP <= DAILY_CAP <= 3M PEN (2% of the supply), a guardian that is neither the deployer nor an attestor, and four distinct attestors none of which is the deployer, all before anything is broadcast. The example environment and the security overview now carry the soft launch caps of 500,000 PEN per release and 1,000,000 PEN per day.
…nges The checks on EARLIEST_SWEEP_TS, QUORUM_FLOOR and PROPOSAL_THRESHOLD caught units slips but let a zeros slip or a superseded date through. Without TEST_DEPLOY the scripts now also refuse a sweep floor before 2027-03-01 00:00 UTC, a quorum floor outside 100,000 to 1,000,000 PEN and a proposal threshold outside 10,000 to 1,000,000 PEN: the floor is immutable, and a threshold no holder reaches could only be lowered by a proposal nobody can make.
…oy parameter checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
Without
TEST_DEPLOY, the deploy scripts check every parameter before anything is broadcast.PER_RELEASE_CAP≤DAILY_CAP≤ 3,000,000 PEN (2% of the supply).EARLIEST_SWEEP_TSnot before 2027-03-01 00:00 UTCQUORUM_FLOORbetween 100,000 and 1,000,000 PENPROPOSAL_THRESHOLDbetween 10,000 and 1,000,000 PENPROPOSAL_THRESHOLDto 50,000 PEN.Testing
forge test(45 pass).