Repository navigation
fix(frontend): correct four small UI defects - #132
Merged
Merged
Conversation
…an filter value, and the sheet close button
…t an h1 The layout already renders SidebarInset as the main landmark. Home and About put a second main inside it, so a screen reader listed two nested main landmarks. They now use a div. The About title was a div, so the page had no h1. The title now holds an h1 with the same look.
The Edit Is Blocked Filter dialog showed True and False as two equal outline buttons, so the user could not see which value the filter had. The control now reads initialFilter. The current value gets the filled button style and aria-pressed=true. The Add Filter menu has no current value and does not change.
On a phone, ResponsiveDialog is a bottom sheet. Its close button used the icon-sm size, 28 px, while the other buttons of the sheet are 32 px high. Below the md breakpoint the close button is now 32 px. On a desktop it stays 28 px, as the close buttons of Dialog and Sheet are.
Owner
Author
|
Independent review: two passes, no high or medium findings. Two low findings stay open.
Fixed after review: the Add Filter menu buttons no longer carry |
…oolean filter The edit dialog marked the stored value as current and ignored the operator. A Not Equals filter matches the opposite value, so the dialog now marks that one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Earlier agents listed six small frontend defects. Four reproduce on main in a real browser, and this PR fixes them. Two do not reproduce, because #126 already fixed them.
What changed
div, not a secondmaininside the layoutmain. The About title now holds anh1. The page looks the same.aria-pressed="true". In the Add Filter menu, which has no current value, the buttons stay plain buttons.ResponsiveDialog) is 32 px, as the other buttons of the sheet are. On a desktop it stays 28 px, as inDialogandSheet.Scope
items-center.Blast Radius
The close button change applies to each
ResponsiveDialogbelow themdbreakpoint. These are the filter dialogs and the demo dialog on /components. The boolean control changes only when it getsinitialFilter, which only the edit dialog sends.Verification
h1, no pressed button in the edit dialog, and a 28x28 close button. With the fixes they pass 10 of 10 times. Two more tests guard the add menu buttons and the 28 px desktop close button.pnpm lint,pnpm build,pnpm test(80 passed), andpnpm test:e2e --workers=4(47 passed) pass.ARIA tree of /about:
Edit Is Blocked Filter, after a True filter
Bottom sheet close button on a 390 px phone, hovered