feat: add back gesture to go up a folder instead of closing app - #4943
Conversation
|
@alexknop thanks for the contribution!! we'll check it asap. As first input, please check the calens file (lacks of endline and description). Get some examples from https://github.com/owncloud/android/tree/master/changelog/ |
|
Thanks for taking care!!, i will give you an extra tips:
Title: Description: What do you think? Summarizing, you can resolve the PR with just two commits: one for the fix, and another one for the calens entry. By fixing these two small issues, we'll move first to code review and then, to QA. Closer to the final! 🚀 PD: any question or whatever you need, don't hesitate to ping us!! |
9990790 to
9b9afa7
Compare
|
@jesmrec done! |
cc80170 to
055aa6f
Compare
There was a problem hiding this comment.
Code is OK now! Good job @alexknop! 💯
One note about commits: all commits must be GPG/PGP signed and include a Signed-off-by line. Use the command: git commit -s -S -m "..." for that. Unfortunately, we won't be able to merge the PR until all commits are properly signed.
Thanks for your effort! 🙌🏻 Let us know if you have any doubts and we will help you!
055aa6f to
e313a5b
Compare
|
@joragua Done! |
|
@alexknop commits are You need to add/link your public key to your GitHub account (Settings > SSH and GPG keys). After that, using the |
Signed-off-by: alex <knopalex@msu.edu>
Signed-off-by: alex <knopalex@msu.edu>
e313a5b to
3912492
Compare
|
@joragua Done. |
|
I did some checks with two different devices, and i found some differences between Android 15 & Android 17, but they could be addressed to other issue: navigation back in Android 17 from
navigation is not correct. But, in any other case, it works fine. Since the main target is the folder navigation instead of closing, i'd set this as approved. That's a good feature @alexknop!! |
Related Issues
App: #4950
Allow Back Gesture in Android to go back a folder instead of closing the application. If on the root folder, it will exit the application.
App:
ReleaseNotesViewModel.ktcreating a newReleaseNote()with String resources (if required)QA