Skip to content

feat: add back gesture to go up a folder instead of closing app - #4943

Merged
joragua merged 2 commits into
owncloud:masterfrom
alexknop:feature/backgesture
Aug 11, 2026
Merged

feat: add back gesture to go up a folder instead of closing app#4943
joragua merged 2 commits into
owncloud:masterfrom
alexknop:feature/backgesture

Conversation

@alexknop

@alexknop alexknop commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Related Issues

App: #4950

Allow Back Gesture in Android to go back a folder instead of closing the application. If on the root folder, it will exit the application.

App:

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

@alexknop
alexknop requested a review from a team as a code owner July 28, 2026 00:28
@jesmrec jesmrec changed the title feat: Add back gesture to go up one folder feat: add back gesture to go up one folder Aug 3, 2026
@jesmrec

jesmrec commented Aug 3, 2026

Copy link
Copy Markdown
Member

@alexknop thanks for the contribution!! we'll check it asap.

As first input, please check the calens file (lacks of endline and description). Get some examples from https://github.com/owncloud/android/tree/master/changelog/

@jesmrec

jesmrec commented Aug 4, 2026

Copy link
Copy Markdown
Member

Thanks for taking care!!, i will give you an extra tips:

  • You updated the branch with a merge commit, we use to rebase branches to prevent extra commits and keeping a cleaner history. It'd be nice to amend it.

  • In case of calens, we noticed you sent two calens commits to the PR. Amending to have only one calens commit is also a good idea. About the content, you can make a shorter description using the Present Perfect Passive tense. Check the template file. My suggestion for your contribution:

Title: Enhancement: Add back gesture

Description: A new gesture has been added in the list of files to browse back to the parent folder instead of closing the app

What do you think?

Summarizing, you can resolve the PR with just two commits: one for the fix, and another one for the calens entry.

By fixing these two small issues, we'll move first to code review and then, to QA. Closer to the final! 🚀

PD: any question or whatever you need, don't hesitate to ping us!!

@alexknop
alexknop force-pushed the feature/backgesture branch from 9990790 to 9b9afa7 Compare August 5, 2026 03:14
@alexknop

alexknop commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

@jesmrec done!

@joragua joragua left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an easy comment @alexknop! After that it will be moved to QA 😄

Comment thread changelog/unreleased/4943 Outdated
@alexknop
alexknop force-pushed the feature/backgesture branch 2 times, most recently from cc80170 to 055aa6f Compare August 6, 2026 21:47
@jesmrec jesmrec closed this Aug 7, 2026
@jesmrec jesmrec reopened this Aug 7, 2026

@joragua joragua left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is OK now! Good job @alexknop! 💯

One note about commits: all commits must be GPG/PGP signed and include a Signed-off-by line. Use the command: git commit -s -S -m "..." for that. Unfortunately, we won't be able to merge the PR until all commits are properly signed.

Thanks for your effort! 🙌🏻 Let us know if you have any doubts and we will help you!

@alexknop

alexknop commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

@joragua Done!

@joragua

joragua commented Aug 10, 2026

Copy link
Copy Markdown
Member

@alexknop commits are Unverified

You need to add/link your public key to your GitHub account (Settings > SSH and GPG keys). After that, using the -S option with your commit command should be enough to sign each commit individually. Let us know if you run into any issues! 🙌🏻

Signed-off-by: alex <knopalex@msu.edu>
@alexknop
alexknop force-pushed the feature/backgesture branch from e313a5b to 3912492 Compare August 11, 2026 01:49
@alexknop

Copy link
Copy Markdown
Contributor Author

@joragua Done.

@joragua joragua left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Moving it to QA 🚀

@joragua joragua changed the title feat: add back gesture to go up one folder feat: add back gesture to go up a folder instead of closing app Aug 11, 2026
@jesmrec

jesmrec commented Aug 11, 2026

Copy link
Copy Markdown
Member

I did some checks with two different devices, and i found some differences between Android 15 & Android 17, but they could be addressed to other issue: navigation back in Android 17 from

  • Custom space root
  • Details
  • txt & audio preview

navigation is not correct.

But, in any other case, it works fine. Since the main target is the folder navigation instead of closing, i'd set this as approved.

That's a good feature @alexknop!!

@joragua
joragua merged commit 1bde011 into owncloud:master Aug 11, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Phone's BACK button exits the app instead of navigating back in the app

3 participants