Add accepted-objective continuity conformance - #245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Boundary
This change adds a reusable conformance boundary for adapters that persist accepted objectives across rejection, recovery, concurrent settlement, restart, instance isolation, and policy revision. Acceptance is reconstructed from the durable binding and complete committed receipt lineage, while candidate-payload persistence remains outside the kernel.
Transition
Before this change, store adapters had no shared executable contract proving that rejected, stale, losing, or cross-instance candidates could not replace the last accepted objective. After this change, each adapter must preserve the accepted binding through failed attempts and recovery, admit only the fresh independently verified successor, keep instances isolated, reconcile exact retries without effects, and mark completion only after the bounded hierarchy is complete.
Evidence
The focused race-enabled conformance suite passed against the memory store, revisioned-register store, and reviewer file store, and the broader kernel and reviewer suites remained green. The repository runner passed all 660 Go tests; build, vet, 69 repository-contract tests, release-note validation and main-branch preflight, and diff checks also passed. The deterministic oracle replayed 320 traces across 145 canonical states and exercised all ten named rejection classes. Two non-blocking test-precision limits remain explicit: several invalid-payload probes also substitute policy identity, and the reference search does not enumerate root-only or pre-policy finish paths.
Commits
Self-review attestation
2746af50573c6b47570bae93280b83748df5c0dc3ca3397ff275d89bdb6d5c934b86b51d3cbdfab0ee628c47fe94d1d4f5767155