[ebariaux]

Description

Fixes #3476.

AssetsFacade.dispatch rejected valid batches containing multiple attribute events for the same asset because it compared the event count with the number of matching assets. Validate distinct target asset IDs so these batches are accepted, while forwarding every original event in its supplied order.

Retain the existing scope checks and reject the whole batch if the scoped lookup does not return every target. Unit tests cover repeated and distinct targets across global, realm and asset scopes, plus partial lookup results representing missing or out-of-scope targets. Enable the standard manager/src/test/groovy directory alongside the existing test directory.

Validation: ./gradlew --offline --no-daemon :manager:test --tests org.openremote.manager.rules.facade.AssetsFacadeTest — 24 tests passed. The initial regression cases were confirmed failing before the fix.

No breaking API changes; this restores valid batch dispatch behavior.

Checklist

• 1. Acceptance criteria of the linked issue(s) are met
• 2. Tests are written and all tests pass (targeted suite: 24 tests)
• 3. Changes are manually tested by you and the reviewer
• 4. Documentation is written or updated (not required for this bugfix)

Discovered during the rules facade scoping review tracked in #2675; this is a separate functional bug fix.

[wborn]

Several newly added tests are failing @ebariaux. Can you have a look?

Failed tests:

• org.openremote.manager.rules.facade.AssetsFacadeTest > asset scope dispatches every event in order for a single event
• org.openremote.manager.rules.facade.AssetsFacadeTest > asset scope dispatches every event in order for distinct targets
• org.openremote.manager.rules.facade.AssetsFacadeTest > asset scope dispatches every event in order for mixed repeated and distinct targets
• org.openremote.manager.rules.facade.AssetsFacadeTest > asset scope dispatches every event in order for two events for one target
• org.openremote.manager.rules.facade.AssetsFacadeTest > asset scope rejects the whole batch for foreign-realm with repeated permitted targets: false
• org.openremote.manager.rules.facade.AssetsFacadeTest > asset scope rejects the whole batch for foreign-realm with repeated permitted targets: true
• org.openremote.manager.rules.facade.AssetsFacadeTest > asset scope rejects the whole batch for missing with repeated permitted targets: false
• org.openremote.manager.rules.facade.AssetsFacadeTest > asset scope rejects the whole batch for missing with repeated permitted targets: true
• org.openremote.manager.rules.facade.AssetsFacadeTest > asset scope rejects the whole batch for outside-subtree with repeated permitted targets: false
• org.openremote.manager.rules.facade.AssetsFacadeTest > asset scope rejects the whole batch for outside-subtree with repeated permitted targets: true

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud