Repository navigation
Prefetch the changelog details so that they can, hopefully, be shown straightaway - #596
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the changelog prefetching and update-dialog changes.
No open issues 🎉
What changed in this PR
This PR prefetches changelog details when the web app detects an update, reducing the wait when users open the update dialog.
Changes:
- Cache completed and in-flight changelog requests by version, allowing retries after failures.
- Add a three-second fetch timeout and loading and failure states in the update dialog.
- Update both package versions to
1.20261102.0.
| File | Description |
|---|---|
src/renderer/src/components/OpenCOR.vue |
Prefetch changelog details when an update becomes available. |
src/renderer/src/components/dialogs/UpdateAvailableDialog.vue |
Display loading and retrieval-failure states. |
src/renderer/src/common/changelog.ts |
Add request caching, timeout handling, and retry support. |
src/renderer/package.json |
Update the renderer package version. |
package.json |
Update the root package version to match. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.