Repository navigation
fix(ci): preserve frozen site_libs from parallel render workers - #432
Closed
ShixiangWang wants to merge 1 commit into
Closed
ShixiangWang wants to merge 1 commit into
ShixiangWang wants to merge 1 commit into
Conversation
Each isolated worker syncs only its document-specific _freeze/<file> directory back. Quarto places shared widget dependencies in _freeze/site_libs, so assets used by frozen pages were discarded with the temporary worker tree. Babelquarto then emitted references to missing assets (notably simplelightbox for ToolLinks), causing the zh dedup step to abort with LEFTOVER and breaking root widget pages too. Stage each worker's _freeze/site_libs and rsync them into the workspace as a union after all workers finish.
Contributor
✅ QMD Format CheckNo new QMD tutorial files to check. |
Member
Author
|
Closing as superseded by #431, which already syncs from parallel workers and adds stale-freeze self-healing. This PR is now redundant and conflicts with that broader build fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
Parallel pre-render workers run in isolated trees and sync only
_freeze/<file>back. Quarto stores shared htmlwidget dependencies in_freeze/site_libs, so those assets were deleted with each temporary worker. Frozen pages—root and zh—then referenced missing assets (for examplesimplelightboxonToolLinks), andprune-zh-duplicates.pycorrectly aborted withLEFTOVER.Fix
_freeze/site_libsper successful worker.xargsfinishes.Verification
_freeze/site_libs.LEFTOVER: _site/zh/ToolLinks.html -> site_libs/simplelightbox...failures.