Repository navigation
ci: run on ubuntu-24.04 and replace the removed Cloudflare Pages action - #551
Merged
Merged
Conversation
ubuntu-latest moved to ubuntu-26.04, which has no prebuilt Ruby 3.0 or 3.1. That breaks the Ruby 3.1 and Rubocop jobs. Pin the runner to ubuntu-24.04, and move the old pinned setup-ruby SHA to v1.328.0. cloudflare/pages-action can no longer be resolved, which breaks the docs job. Deploy with cloudflare/wrangler-action and the equivalent `pages deploy` command. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CEuUhrasuRFEFW6KcTW7QN
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CEuUhrasuRFEFW6KcTW7QN
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Three CI checks currently fail on every PR before running anything (seen on #550):
Unavailable version 3.1.7 for ruby on ubuntu-26.04ubuntu-latestis now ubuntu-26.04, and ruby-builder has no Ruby 3.0 or 3.1 builds for it404downloadingruby-3.0.0-ubuntu-26.04.tar.gzUnable to resolve action cloudflare/pages-action, not foundChanges:
runs-on: ubuntu-24.04. Ruby 3.0.7 and 3.1.7 are prebuilt for 24.04.ruby-version: '3.0'is quoted so it means 3.0, not the YAML float3.cloudflare/pages-action@v1becomescloudflare/wrangler-action(v4.1.3, pinned by SHA). It runspages deploy doc --project-name=nylas-ruby-sdk-reference --branch=<same branch as before>, uses the same two secrets, and the environment URL now comes from thedeployment-urloutput.Check names are unchanged, so the required checks (Ruby 3, Ruby 3.1, Ruby 3.2, test) still match.
Checked locally in Docker:
rspecpasses with 320 examples,rubocopreports no offenses across 80 files, andyardbuilds.rspecpasses with 320 examples.The Pages deploy step can only be verified by this PR's own docs run.
Not changed, worth a follow-up: in
rspec.ymlthe matrix entryruby: 3.0is a YAML float, so the "Ruby 3" job runs the latest 3.x, not 3.0. Quoting it would rename the check to "Ruby 3.0", and the branch protection rule would then need updating, so I left it.License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.
🤖 Generated with Claude Code
https://claude.ai/code/session_01CEuUhrasuRFEFW6KcTW7QN