Skip to content

fix: stop false-red Check runs - #14

Merged
coreybutler merged 1 commit into
mainfrom
fix/ci-signal
Oct 24, 2026
Merged

coreybutler merged 1 commit into
mainfrom
fix/ci-signal

Conversation

@coreybutler

Copy link
Copy Markdown
Contributor

Summary

  • GITHUB_TOKEN is a repo installation token, not the pusher PAT, so org team membership always 404s. github-guard now allows OWNER / MEMBER / COLLABORATOR via author_association.
  • Link-mode CLI tests stub Authenticode so unsigned SeedVersion node.exe stubs no longer trip NVM4302.
  • Workflow-only PRs skip app tests instead of failing Fail On No App Changes.

Test plan

  • Open this PR as an org member and confirm Guard Sensitive Changes is green when .github/** changes
  • Confirm test (nvm) is green, including nvm/test/commands
  • Fork PRs that touch .github/** still fail the guard

GITHUB_TOKEN cannot read org teams, so github-guard now trusts
author_association. Link-mode CLI tests stub Authenticode for unsigned stubs.
@coreybutler
coreybutler merged commit dfe9ce8 into main Oct 24, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant