Skip to content

test: remove console.log call in node_run_list - #65572

Open
aduh95 wants to merge 1 commit into
nodejs:mainfrom
aduh95:no-console-log
Open

test: remove console.log call in node_run_list#65572
aduh95 wants to merge 1 commit into
nodejs:mainfrom
aduh95:no-console-log

Conversation

@aduh95

@aduh95 aduh95 commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

That console.log looks like a debug thing, when in fact the test relies on it as this is a message test. Switch to using the more appropriate inherit value.

Refs: https://github.com/nodejs/node/pull/65552/changes#r3862720795

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Aug 26, 2026
@codecov

codecov Bot commented Aug 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.07%. Comparing base (2743045) to head (a1fa535).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #65572   +/-   ##
=======================================
  Coverage   90.06%   90.07%           
=======================================
  Files         751      751           
  Lines      254917   254917           
  Branches    48133    48123   -10     
=======================================
+ Hits       229580   229604   +24     
- Misses      16493    16494    +1     
+ Partials     8844     8819   -25     

see 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 28, 2026
@panva panva added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Aug 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run. request-ci Add this label to start a Jenkins CI on a PR. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants