Skip to content

process: stop _kill on missing arguments #65072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Archkon wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −1
Open

process: stop _kill on missing arguments #65072

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/node_process_methods.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ static void Kill(const FunctionCallbackInfo<Value>& args) {
Local<Context> context = env->context();

if (args.Length() < 2) {
THROW_ERR_MISSING_ARGS(env, "Bad argument.");
return THROW_ERR_MISSING_ARGS(env, "Bad argument.");
}

int pid;
Expand Down
8 changes: 8 additions & 0 deletions test/parallel/test-process-kill-pid.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,14 @@
const common = require('../common');
const assert = require('assert');

for (const args of [[], [process.pid]]) {
assert.throws(() => process._kill(...args), {
code: 'ERR_MISSING_ARGS',
name: 'TypeError',
message: 'Bad argument.'
});
}

// Test variants of pid
//
// null: TypeError
Expand Down
Loading