Skip to content

[v22.x backport] src: add cli option to exclude env vars on dr - #56055

Merged
aduh95 merged 3 commits into
nodejs:v22.x-stagingfrom
RafaelGSS:backport-55697-to-v22
Dec 10, 2024
Merged

[v22.x backport] src: add cli option to exclude env vars on dr #56055
aduh95 merged 3 commits into
nodejs:v22.x-stagingfrom
RafaelGSS:backport-55697-to-v22

Conversation

@RafaelGSS

@RafaelGSS RafaelGSS commented Nov 28, 2024

Copy link
Copy Markdown
Member

PR-URL: #55697
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Richard Lau rlau@redhat.com

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. labels Nov 28, 2024
@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 29, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 29, 2024
@nodejs-github-bot

nodejs-github-bot commented Nov 29, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63775/

@richardlau

richardlau commented Nov 29, 2024

Copy link
Copy Markdown
Member

Since #55788 also didn't backport to v22.x-staging cleanly (because #55697, which this PR backports, needs to land first), perhaps it should also be part of this backport PR as a second commit?

@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 3, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 3, 2024
@nodejs-github-bot

nodejs-github-bot commented Dec 3, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63854/

@nodejs-github-bot

nodejs-github-bot commented Dec 4, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63870/

@nodejs-github-bot

nodejs-github-bot commented Dec 4, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63874/

@nodejs-github-bot

nodejs-github-bot commented Dec 4, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63876/

@RafaelGSS RafaelGSS added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. labels Dec 6, 2024
@aduh95

aduh95 commented Dec 6, 2024

Copy link
Copy Markdown
Contributor

Can you please add #56130 to this backport PR so the correct version is reported for Version 4 section?

@RafaelGSS RafaelGSS added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 7, 2024
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 7, 2024
@nodejs-github-bot

nodejs-github-bot commented Dec 7, 2024

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63935/

RafaelGSS and others added 3 commits December 10, 2024 22:15
@RafaelGSS @aduh95
src: add cli option to preserve env vars on dr
0aee9af 
PR-URL: nodejs#55697
Backport-PR-URL: nodejs#56055
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@RafaelGSS @aduh95
doc: sort --report-exclude alphabetically
803cc3b 
PR-URL: nodejs#55788
Backport-PR-URL: nodejs#56055
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
PR-URL: nodejs#55697
@legendecas @aduh95
doc: add report version and history section
ba63702 
PR-URL: nodejs#56130
Backport-PR-URL: nodejs#56055
Refs: nodejs#56068
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
PR-URL: nodejs#55697
@aduh95
aduh95 force-pushed the backport-55697-to-v22 branch from 96751a3 to ba63702 Compare December 10, 2024 21:25
@aduh95
aduh95 merged commit ba63702 into nodejs:v22.x-staging Dec 10, 2024
@aduh95

aduh95 commented Dec 10, 2024

Copy link
Copy Markdown
Contributor

Landed in 4f85047...ba63702

ruyadorno pushed a commit that referenced this pull request Jan 5, 2025
@RafaelGSS @ruyadorno
src: add cli option to preserve env vars on dr
2e3ca1b 
PR-URL: #55697
Backport-PR-URL: #56055
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
ruyadorno pushed a commit that referenced this pull request Jan 5, 2025
@RafaelGSS @ruyadorno
doc: sort --report-exclude alphabetically
8cb3c20 
PR-URL: #55788
Backport-PR-URL: #56055
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
PR-URL: #55697
ruyadorno pushed a commit that referenced this pull request Jan 5, 2025
@legendecas @ruyadorno
doc: add report version and history section
5263086 
PR-URL: #56130
Backport-PR-URL: #56055
Refs: #56068
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
PR-URL: #55697
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@RafaelGSS @nodejs-github-bot @richardlau @aduh95 @legendecas