refactor/file service - #9028
Merged
Merged
Conversation
max-nextcloud
commented
Aug 11, 2026
max-nextcloud
commented
Collaborator
- refactor(backend): introduce FileService
- chore(refactor): separate file getters for share and user
- chore(refactor): get file in controller for apiService->create
- chore(refactor): use constructor promotion for DocumentServce
- chore(refactor): move file getters into FileService
max-nextcloud
force-pushed
the
refactor/file-service
branch
10 times, most recently
from
August 12, 2026 08:50
f672b62 to
ccbb342
Compare
max-nextcloud
marked this pull request as ready for review
August 12, 2026 09:00
grnd-alt
approved these changes
Aug 18, 2026
max-nextcloud
force-pushed
the
refactor/file-service
branch
2 times, most recently
from
August 18, 2026 15:13
5faa125 to
d3f9fe3
Compare
max-nextcloud
force-pushed
the
refactor/file-service
branch
from
August 18, 2026 18:22
d3f9fe3 to
c9d35f7
Compare
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
…vice Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
max-nextcloud
force-pushed
the
refactor/file-service
branch
3 times, most recently
from
August 19, 2026 04:49
c4cca9f to
7232808
Compare
* `checkSharePermissions` has not been throwing `NotPermittedException` for a while. See #3765 . * `InvalidArgumentException` was not being handled. * throw `NotFoundException` if file cannot be found and there is no share token. Signed-off-by: Max <max@nextcloud.com>
max-nextcloud
force-pushed
the
refactor/file-service
branch
from
August 19, 2026 05:35
7232808 to
5907ff4
Compare
grnd-alt
approved these changes
Aug 19, 2026
| } | ||
|
|
||
| public function unlock(File $file): void { | ||
| if (!$this->lockManager->isLockProviderAvailable()) { |
Member
There was a problem hiding this comment.
nitpick: is there an advantage to calling this method here?
lockManager checks if there's a lockprovider as well, so if there is a lockProvider lockManager->getLockProvider is called twice?
same in the lock method
|
|
||
| // Workaround to always open files with edit permissions if multiple occurrences of | ||
| // the same file id are in the user home, ideally we should also track the path of the file when opening | ||
| usort($files, static fn (Node $a, Node $b) => ($b->getPermissions() & Constants::PERMISSION_UPDATE) <=> ($a->getPermissions() & Constants::PERMISSION_UPDATE)); |
Member
There was a problem hiding this comment.
I think this can be done more efficient. If I get this right this sorts the array by comparing if the PERMISSION_UPDATE is present, so essentially is a search for an element in the array which has the PERMISSION_UPDATE without control over which of those comes first?
as afterwards it's checked if there's also PERMISSION_READ I think this can be simplified into a for loop that searches for a file with PERMISSION_READ and PERMISSION_UPDATE.
something like this:
foreach ($files as $file) {
if ($file->getPermissions() & (Constants::PERMISSION_UPDATE | Constants::PERMISSION_READ) === 3) {
return $file;
}
github-project-automation
Bot
moved this from 👀 In review
to ☑️ Done
in 📝 Productivity team
21 tasks
max-nextcloud
added a commit
that referenced
this pull request
Aug 19, 2026
Addresses #9028 (comment) . Signed-off-by: Max <max@nextcloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.