feat: Add support for multiple consecutive banners in configs. - #860
Merged
jeffkala merged 4 commits intoAug 14, 2026
Merged
Conversation
swanandtambe
requested review from
itdependsnetworks,
jeffkala and
qduk
as code owners
July 17, 2026 06:56
added 2 commits
July 17, 2026 12:34
| hostname multi-banner-xr | ||
| ! | ||
| banner exec ~ | ||
| * exec banner line 1 * |
Contributor
There was a problem hiding this comment.
can you add a test that shows an empty line here?
Contributor
Author
There was a problem hiding this comment.
Is this to test an empty (whitespace only) line in the banner?
Contributor
There was a problem hiding this comment.
not really, something like this
banner exec ~
* exec banner line 1
* exec banner line 2
It was not clear to me from the code if this was taken into consideration.
jeffkala
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.