Repository navigation
Pin wareki to 1.x - #22
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bump ruby/setup-ruby to v1.335.0 so that Ruby 4.0 can be resolved. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Drop 3.4 / 4.0 from the matrix for now: they need bigdecimal and nkf added as gem dependencies. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
koyo-miyamura
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
wareki 2.0.0 (released on 2026-07-13) made zero-padded output the default for the era year (
%Jg). See "Use zero padded format on default" in its ChangeLog.This gem depends on
wareki >= 1.1.0and there is noGemfile.lock, so CI now installs wareki 2.1.0 and these specs fail on every Ruby version in the matrix:spec/format_string/transform_rules/dates_spec.rb:125expected"3", got"03"spec/format_string/transform_rules/dates_spec.rb:194expected"令和元", got"令和01"Users who install this gem can also get wareki 2.x, which changes the output of Japanese era date formats.
Changes
warekito>= 1.1.0, < 2in the gemspec.Supporting wareki 2.x can be done in a separate PR.
How to verify
🤖 Generated with Claude Code