Repository navigation
Update function descriptions to match actual behavior - #21
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
koyo-miyamura
approved these changes
Oct 26, 2026
This was referenced Oct 26, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
The function descriptions in
lib/xls_function/locales/*.ymlwere mostly based on Microsoft Excel's documentation.Some of them did not match how this library actually behaves, so users could not rely on them.
Changes
ja.ymlbased on the implementation inlib/xls_function/evaluators/functions/.en.ymlas a translation of the newja.yml, so both locales describe the same behavior.descriptionstext changed. No code changes, and no keys were added or removed (57 descriptions in each file).errorsis unchanged.Examples of descriptions that now match the actual behavior:
DBCSLEFT/RIGHTnum_charsis optionalnum_charsreturns#VALUE!AND/ORIFSnil) when no condition is TRUESWITCH#N/Awhen nothing matches and no default is givenISNUMBER"123"returns FALSECHARUNICHARfor other charactersHow to verify
Anyone can check the behavior described above in
bin/console:To see the descriptions in each locale:
🤖 Generated with Claude Code